Skip to content

feat: add custom progress reporting to anywidget display mode #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat: add custom progress reporting to anywidget display mode #1733

wants to merge 4 commits into from

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented May 14, 2025 •
edited
Loading

Also,

  • chore: add callback argument to _read_gbq_colab
  • chore: create _to_pandas_batches_colab with callback argument

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 14, 2025
@tswast tswast force-pushed the b409104302-callback branch from 21ca375 to f8a3f64 Compare September 3, 2025 22:05
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Sep 3, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@tswast tswast changed the title chore: add callback argument to _read_gbq_colab feat: add custom progress reporting to anywidget display mode Sep 4, 2025
tswast
tswast commented Sep 6, 2025
View reviewed changes
bigframes/core/blocks.py
page_size: Optional[int] = None,
max_results: Optional[int] = None,
allow_large_results: Optional[bool] = None,
callback: Callable = lambda _: None,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion offline, we may want to provide a global progress publisher object rather than add callbacks to each method that needs them.

@tswast tswast closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast